Add hermes as a library and enable download tracking #1626
Conversation
This PR adds hermes as a dedicated library: https://huggingface.co/LMD0311/HERMES
dk-liang
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca and
ngxson
as code owners
There was a problem hiding this comment.
Thanks for your PR! I left a few comments before merging. Also it's best to merge https://huggingface.co/LMD0311/HERMES/discussions/1 before merging this PR to make sure downloads are correctly counted.
| @@ -1175,6 +1175,13 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = { | |||
| countDownloads: `path:"model_vae_fp16.pt"`, | |||
| snippets: snippets.threedtopia_xl, | |||
| }, | |||
| hermes: { | |||
There was a problem hiding this comment.
can you add "hermes" entry in alphabetical order in the mapping? Thanks!
| repoName: "HERMES", | ||
| repoUrl: "https://github.com/LMD0311/HERMES", | ||
| filter: false, | ||
| countDownloads: `path:"ckpt/hermes_final.pth" OR path_extension:"pth" OR path_prefix:"ckpt/" OR path_prefix:"data/"`, |
There was a problem hiding this comment.
we do not want to double count downloads. Therefore we usually count downloads only on a single file that you know for sure is required to instantiate the model. Could it be
| countDownloads: `path:"ckpt/hermes_final.pth" OR path_extension:"pth" OR path_prefix:"ckpt/" OR path_prefix:"data/"`, | |
| countDownloads: `path:"ckpt/hermes_final.pth"`, |
only for instance?
There was a problem hiding this comment.
countDownloads: `path:"ckpt/hermes_final.pth"` is acceptable.
Alternatively, would countDownloads: `path_prefix:"ckpt/" OR path_prefix:"data/"be suitable, as some users may only require the training dataset?
There was a problem hiding this comment.
If https://huggingface.co/LMD0311/HERMES/tree/main/data is where the training dataset is, I would highly recommend to upload it as a separate dataset repo. This way you can have proper download count for both the model part and the dataset part separately + you're able to document them separately as well (+ have separate community tabs). This is the usual way to handle a release on the Hub and it comes with many handy features - especially for user discoverability.
There was a problem hiding this comment.
Thanks for help, let's use countDownloads: `path:"ckpt/hermes_final.pth"` for convenience. 🤔
There was a problem hiding this comment.
Fine for me! This PR is now ready to be merged as soon as #1626 (comment) is addressed :)
There was a problem hiding this comment.
Sorry for missing that, I've reorganized the content alphabetically.
This PR adds hermes as a dedicated library: https://huggingface.co/LMD0311/HERMES