WIP: upload progress bar on CLI #1730
Draft
+224
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coyotte508
reviewed
Sep 5, 2025
Comment on lines
+114
to
+118
| stop(): void { | ||
| if (!this.isQuiet && this.cliProgressAvailable && this.multibar) { | ||
| this.multibar.stop(); | ||
| } | ||
| } |
There was a problem hiding this comment.
you can also add:
[Symbol.dispose](): void { this.stop();}then you can do using progressManager = ... and avoid try/catch on it
There was a problem hiding this comment.
I tried that but for some reason it caused the progress bar to never finish and the cli was hanging after committing (possible but unlikely caused by something else)
|
let me know when this is ready for review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds progress bars to file uploads.
Adds
--xet/-xflag to use xet for uploads, defaults to false