Support metal cpp sdk #291
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
reviewed
Nov 7, 2025
Comment on lines
-19
to
+31
| "relu_metal/relu.mm", | ||
| "relu_metal/relu.metal", | ||
| "relu_metal/common.h", | ||
| "relu_metal_cpp/relu.cpp", | ||
| "relu_metal_cpp/metallib_loader.mm", | ||
| "relu_metal_cpp/relu_cpp.metal", | ||
| "relu_metal_cpp/common.h", |
Member
There was a problem hiding this comment.
I think it would be best to keep relu as is and add an extra relu-metal-cpp example.
|
|
||
| # Build inputs | ||
| apple-sdk_15, | ||
| metal-cpp, |
Member
There was a problem hiding this comment.
Let's keep them lexicographically sorted.
| if [[ "$*" =~ "metallib" ]]; then | ||
| # If metallib is requested, find the air-lld from the Metal toolchain | ||
| METALLIB_BIN=$(ls /var/run/com.apple.security.cryptexd/mnt/com.apple.MobileAsset.MetalToolchain*/Metal.xctoolchain/usr/bin/air-lld 2>/dev/null | head -n 1) |
Member
There was a problem hiding this comment.
metallib is a binary too :)
Also, this path is not stable, e.g. it doesn't exist on my macOS 26 installation.
Comment on lines
+82
to
+103
| # Remove the '-sdk macosx metallib' and other unsupported flags from the command arguments | ||
| ARGS=$(echo "$@" | sed 's/-sdk macosx metallib //' | sed 's/-mmacosx-version-min=[^ ]* //') | ||
| # Add platform version for macOS 15+ to support Metal 3.2 / AIR 2.7 | ||
| $METALLIB_BIN -platform_version macos 15.0 15.0 $ARGS | ||
| elif [[ "$*" =~ "metal" ]]; then | ||
| # If metal is requested, find the metal compiler from the Metal toolchain | ||
| METAL_BIN=$(ls /var/run/com.apple.security.cryptexd/mnt/com.apple.MobileAsset.MetalToolchain*/Metal.xctoolchain/usr/bin/metal 2>/dev/null | head -n 1) | ||
| if [ -z "$METAL_BIN" ]; then | ||
| echo "Error: Metal compiler not found" >&2 | ||
| exit 1 | ||
| fi | ||
| # Remove the '-sdk macosx metal' from the command arguments | ||
| ARGS=$(echo "$@" | sed 's/-sdk macosx metal //') | ||
| $METAL_BIN $ARGS | ||
| else | ||
| # In all other cases, just use the host xcrun | ||
| unset DEVELOPER_DIR | ||
| /usr/bin/xcrun $@ | ||
| fi |
Member
There was a problem hiding this comment.
I think most of this is not needed with #290 merged, we do not call xcrun anymore for metal and metallib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new
metal-cppkernel dependency. This is a follow up to the metal-cpp support in hf nix: huggingface/hf-nix#128 and enables kernels to use the cpp headers to drive metal kernels.Changes:
examples/relu/build.toml. since they both produce metal output we can only build one at a time..xcrunHostcommand to respect the cryptex location of the latest metal toolchain on the host. This may need to be improved in line with Metal 4 Update to macOS SDK 26 and Metal 4 #290example usage