Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move executorch export to optimum-executorch #1

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

echarlaix
Copy link
Collaborator

@echarlaix echarlaix commented Jan 21, 2025

Following huggingface/optimum#2090 (comment)

ExecuTorch export (introduced in huggingface/optimum#2090) is moved in optimum-executorch see huggingface/optimum#2165

@@ -0,0 +1,67 @@
# Copyright (c) Meta Platforms, Inc. and affiliates.
Copy link
Collaborator Author

@echarlaix echarlaix Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the copyrights in 2a9b828 to standardize everything, is it ok for you @guangy10 or would you like me to revert ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's ok

@echarlaix echarlaix marked this pull request as ready for review January 23, 2025 09:36
Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for handling this

setup.py Show resolved Hide resolved
@guangy10
Copy link

@echarlaix do you mind explaining the motivation of moving to optimum-executorch? I remember you briefly mentioned that during out meetup at HF Paris office but can't recall the details. I want to make sure such a move will not potentially decrease the visibility executorch to HF users. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants