-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move executorch export to optimum-executorch #1
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,67 @@ | |||
# Copyright (c) Meta Platforms, Inc. and affiliates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied from current optimum integration https://github.com/huggingface/optimum/blob/ded71c2a66bf7a41c4350677db8d32b424dc8d09/optimum/commands/export/executorch.py#L1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for handling this
@echarlaix do you mind explaining the motivation of moving to optimum-executorch? I remember you briefly mentioned that during out meetup at HF Paris office but can't recall the details. I want to make sure such a move will not potentially decrease the visibility executorch to HF users. Thanks! |
Following huggingface/optimum#2090 (comment)
ExecuTorch export (introduced in huggingface/optimum#2090) is moved in
optimum-executorch
see huggingface/optimum#2165