-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing HL_DS_DISTRIBUTED_ATTENTION_SEQ_DIM as it's not needed from 1.20 #1726
base: main
Are you sure you want to change the base?
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@bhargaveede thanks. The workaround has already been removed in the next DeepSpeed update, so it is completely safe to remove it for the 1.20 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@bhargaveede This is still needed for SynapseAI 1.20 right? |
The workaround in DeepSpeed for SynapseAI 1.19.0 included the |
Thanks for the explanation! I meant "still needed for 1.19" actually, which is the case if I understand correctly. I'll probably merge this PR in the release branch first since I prefer keeping the main branch compatible with the latest Synapse release. |
@regisss Flag is needed for 1.19. |
1.20 Release
What does this PR do?
Fixes # (issue)
Before submitting