Skip to content

Conversation

@slokesha
Copy link
Contributor

@slokesha slokesha commented Jul 29, 2025

What does this PR do?

Mamba model to use the PScan Kernel which will improve its throughput.
HL-SMI Version: hl-1.22.0-rc-fw-
Driver Version: 1.22.0-48ef525
Nic Driver Version: 1.22.0-48ef525

image: artifactory-kfs.habana-labs.com/docker-local/1.22.0/ubuntu22.04/habanalabs/pytorch-installer-2.7.1:1.22.0-543

G2:
image

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@slokesha slokesha marked this pull request as ready for review July 29, 2025 17:56
@slokesha slokesha requested a review from regisss as a code owner July 29, 2025 17:56
Copy link
Collaborator

@karol-brejna-i karol-brejna-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contains changes in the logic itself, as well as docs and tests.
Looks good.

@regisss
Copy link
Collaborator

regisss commented Aug 11, 2025

@slokesha This doesn't work with SynapseAI v1.21 right?

@slokesha
Copy link
Contributor Author

@slokesha This doesn't work with SynapseAI v1.21 right?

yes it fails with error:
File "/root/hs/optimum-habana/optimum/habana/transformers/models/mamba/modeling_mamba.py", line 29, in Run_Mamba_Forward_Gaudi
state_out_h = torch.ops.hpu.mamba_pscan(in_state_h, in_x_h, in_dt_h, in_A_h, in_B_h)
File "/usr/local/lib/python3.10/dist-packages/torch/_ops.py", line 1232, in getattr
raise AttributeError(
AttributeError: '_OpNamespace' 'hpu' object has no attribute 'mamba_pscan'

Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, let's wait for Synapse 1.22 to be released before merging this one in main then 🙂

@astachowiczhabana astachowiczhabana removed their assignment Sep 11, 2025
"throughput": 3100.9825044466907
"throughput": 20208.867657545277
},
"gaudi3": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gaudi3 baselines are unchanged?

@karol-brejna-i
Copy link
Collaborator

@slokesha Are you still working on the PR? It looks like only a confirmation of baseline numbers is required and it could be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants