Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AWS Neuron sdk 2.21 #754

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Use AWS Neuron sdk 2.21 #754

wants to merge 18 commits into from

Conversation

dacorvo
Copy link
Collaborator

@dacorvo dacorvo commented Dec 23, 2024

What does this PR do?

This bumps the AWS Neuron SDK version to use AWS Neuron SDK 2.21, which is the first SDK compatible with trn2 instances.

The underlying pytorch version is now 2.5.1, which implies significant changes in the XLA stack.

This leads to compilation errors in:

  • training tests,
Invoking RemoveOptimizationBarriers pass
2025-01-03 08:45:20.301338: F hilo/MLIRPasses/Transforms/VerifyAliasing.cc:125] false && "Read after write on aliased input/output buffer."
  • stable diffusion tests.
***** Compiling unet *****
Using Neuron: --optlevel 2
2025-01-03T08:46:19Z [TEN404] (_convolution.158) Internal tensorizer error: RelaxPredicates:inst should be valid after relaxing predicates
  • swin tests.
[TEN404] (_divide.1146) Internal tensorizer error: BirCodeGenLoop:Too many strides! {{{{0,+,1}[4],+,0}[2],+,4}[16],+,0}[2]

@dacorvo dacorvo force-pushed the aws_neuron_sdk_2.21 branch from 1d60cef to e3e9c80 Compare December 23, 2024 16:48
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@dacorvo dacorvo force-pushed the aws_neuron_sdk_2.21 branch from 54d54a0 to fef3fa8 Compare December 24, 2024 08:57
@dacorvo dacorvo force-pushed the aws_neuron_sdk_2.21 branch 4 times, most recently from 00c9655 to fa0d0b9 Compare January 2, 2025 15:23
@dacorvo dacorvo marked this pull request as ready for review January 3, 2025 09:10
@JingyaHuang
Copy link
Collaborator

@dacorvo For failing vision model tests, it seems that batch_size != 1 will all fail (in our tests, we applied batch_size = 2). I will open a ticket in neuron SDK repo, I could set batch size to 1 to make the CIs green, but I doubt if we should bump to that version...

@dacorvo dacorvo force-pushed the aws_neuron_sdk_2.21 branch 2 times, most recently from 181182f to 083a98f Compare January 7, 2025 14:40
@dacorvo dacorvo force-pushed the aws_neuron_sdk_2.21 branch from 083a98f to 466d6d9 Compare January 7, 2025 14:58
Copy link

github-actions bot commented Feb 1, 2025

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 1, 2025
@dacorvo dacorvo removed the Stale label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants