-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for phi4 #764
base: main
Are you sure you want to change the base?
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@jlonge4 thank you very much for this pull-request: adding support for phi4 would be awesome. We are however heavily refactoring the export mechanism to remove the dependency to Can you take a look at that pull-request and see if it would make it easier for you to add support for phi4 based on the new HLO backend ? |
Hi there @dacorvo , just took a look at the difference and it certainly seems a lot slimmer! I think my effort would be the same in regard to the most important part for this which is the |
This PR adds support for Meta's Phi-4 model by adapting the existing LLaMA implementation.
The Phi-4 architecture follows the LLaMA architecture closely, with the main difference being in how the weights are stored (fused
qkv_proj
andgate_up
vs separate projections).