-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onnx support for FNet #802
base: main
Are you sure you want to change the base?
Conversation
Hi @hazrulakmal! Thanks for adding support for FNet 🔥 |
Would even do To test only your addition: |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
It seems that FNet integration does not pass some of the tests. I think It may be attributed to the operator |
What is the error message you get? Maybe you just need to specify a higher opset version in your model config (see an example here). |
Thanks! Based on this onnx documentation, Fourier transform related operators, DFT and STFT, are supported since version 17 so I have bumped up the opset version to 17 as per you suggested but still receives the error message below
Also did bump it to 18 and 19 but still to no avail and received I checked the conversion using the following block of code as per suggested in this doc
on top of that, I also did
|
@hazrulakmal Thank you for investigating! Can you try Reading pytorch/pytorch#81075 I would also assume that with opset 17 torch.fft.fftn should be supported. Is it the op used in FNet implementation? According to this issue, STFT is not supported yet: pytorch/pytorch#81075 (comment) |
What does this PR do?
Fixes #555
Add support for FNet, an architecture similar to BERT.
@fxmarty, @chainyo & @michaelbenayoun, could you give me a few pointers as to how to test the integration locally?
I did try to check the integration by following this doc but I'm not quite sure why I keep getting
ModuleNotFoundError: No module named 'onnx'
error text despite setting up the my development setup such thatpip install -e ".[dev]"
Before submitting