Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move torchvision to the torch extra #297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move torchvision to the torch extra #297

wants to merge 1 commit into from

Conversation

nonsleepr
Copy link

With torchvision being made a requirement, installing smolagents doesn't feel like installing something "smol". torch is an extra and torchvision should be put there too.

albertvillanova
albertvillanova reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I agree.

Indeed, we had already done this. But is seems we had to revert it because of an import issue. See:

We need to be able to reproduce the issue and then fix it before merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertvillanova albertvillanova albertvillanova left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nonsleepr @albertvillanova