Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marlin: support tp>1 when group_size==-1 #2032

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

danieldk
Copy link
Member

@danieldk danieldk commented Jun 6, 2024

What does this PR do?

When group_size==-1 we have just one scales group that is shared between
all quantized matrix rows. So, in this case we should not try to get the
scales sharded by row.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe put the integration test with num_shard=2 to check behavior here?

Edit: It's already tested, it's the num_groups=-1 variants that are not checked (it's ok to not test it all the time)

@danieldk danieldk merged commit 0d96468 into main Jun 6, 2024
8 checks passed
@danieldk danieldk deleted the feature/marlin-groupsize-1-tp branch June 6, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants