fix: set sharded true if WORLD_SIZE is set #2062
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny PR that simply set assumes
sharded
is true if aWORLD_SIZE
env is set.Adding because I wasted time debugging when I just forgot to set
--sharded
along with theWORLD_SIZE
andRANK
env vars. This PR allows--sharded
to be inferred and is for dev conveniencenote** we already do this in the launcher
text-generation-inference/launcher/src/main.rs
Lines 518 to 521 in 11ea9ce