Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for supported models #2471

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Small fixes for supported models #2471

merged 3 commits into from
Oct 14, 2024

Conversation

osanseviero
Copy link
Contributor

  • Remove supported hardware from titles
  • Link to non-core model serving doc + remove unrelated

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, left a minor comment.

docs/source/supported_models.md Outdated Show resolved Hide resolved
docs/source/_toctree.yml Outdated Show resolved Hide resolved
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh also, can you run python update_doc.py that'll fix the failing test.

You might need to run npm i -g @redocly/cli@latest before hand.

(I don't have approve rights on this repo, but everything else LGTM.)

@Narsil Narsil merged commit ce28ee8 into main Oct 14, 2024
3 checks passed
@Narsil Narsil deleted the supported_models_fix branch October 14, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants