Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting back the NCCL forced upgrade. #2999

Merged
merged 14 commits into from
Feb 14, 2025
Merged

Putting back the NCCL forced upgrade. #2999

merged 14 commits into from
Feb 14, 2025

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Feb 7, 2025

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil Narsil marked this pull request as ready for review February 7, 2025 15:41
drbh
drbh previously approved these changes Feb 13, 2025
Copy link
Collaborator

@drbh drbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Narsil Narsil merged commit d6881c3 into main Feb 14, 2025
19 checks passed
@Narsil Narsil deleted the put_back_nccl branch February 14, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants