Skip to content

fix multi-modality apply chat template issue #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sywangyi
Copy link
Contributor

@sywangyi sywangyi commented Jun 6, 2025

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sywangyi
Copy link
Contributor Author

sywangyi commented Jun 6, 2025

@regisss @Narsil please help review

@sywangyi sywangyi changed the title fix multi-modality apply template issue fix multi-modality apply chat template issue Jun 6, 2025
@regisss
Copy link
Collaborator

regisss commented Jun 12, 2025

@sywangyi Can you add a description of the issue and how this PR solves it please?

@sywangyi
Copy link
Contributor Author

sywangyi commented Jun 12, 2025

#3257 describe it, And I just give a WA as skipping applying chat template to VLM model like llava qwenvl

@regisss
Copy link
Collaborator

regisss commented Jun 12, 2025

Gently pinging @Narsil for review

@Narsil
Copy link
Collaborator

Narsil commented Jun 18, 2025

This is most likely a wrong fix. We cannot just skip using templates on some models because the answer is not to our liking.

We need to fix the template instead, no ? But overriding like this is most likely purely wrong.

@sywangyi
Copy link
Contributor Author

VLM template input like,
conversation = [
{

  "role": "user",
  "content": [
      {"type": "text", "text": "What is shown in this image?"},
      {"type": "image"},
    ],
},

]

which is different with llm.
{"role": "user", "content": "Who are you?"},

so we may need reconstruct the msg for vlm before apply chat template. also, there is model that does not have chat template. we need to handle it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants