Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Model card for GPT2 #37101

Merged
merged 5 commits into from
Apr 7, 2025
Merged

Conversation

ash-01xor
Copy link
Contributor

@ash-01xor ash-01xor commented Mar 29, 2025

What does this PR do?

This PR updates the model-card for the GPT2 model, as described in #36979, in an attempt to standardize all model-cards.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@stevhliu

Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@github-actions github-actions bot marked this pull request as draft March 29, 2025 10:53
@ash-01xor ash-01xor changed the title Update Model card for GPT22 Update Model card for GPT2 Mar 29, 2025
@ash-01xor ash-01xor marked this pull request as ready for review March 29, 2025 13:31
@github-actions github-actions bot requested a review from stevhliu March 29, 2025 13:31
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Missing a few examples like quantization and the transformers-cli, but otherwise looks to be in pretty good shape 🤗

@ash-01xor ash-01xor force-pushed the ash-Model-Card-gpt2 branch from a559b2e to 3679cd7 Compare April 3, 2025 16:44
@ash-01xor
Copy link
Contributor Author

Updated as per the changes requested and added the respective examples

@ash-01xor ash-01xor requested a review from stevhliu April 3, 2025 17:24
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the quantization example, added a few more comments!

@ash-01xor
Copy link
Contributor Author

Updated the file based on the recent suggestions @stevhliu

@ash-01xor ash-01xor requested a review from stevhliu April 5, 2025 10:43
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🤗

@stevhliu stevhliu merged commit 3a826a4 into huggingface:main Apr 7, 2025
10 checks passed
vasqu pushed a commit to vasqu/transformers that referenced this pull request Apr 7, 2025
* Update Model card for gpt2

* Update link for gpt2 space

* fixes docs based on suggestions

* Add transformers-cli and quantization example for GPT-2

* Remove resources and flash attention docs and fix typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants