Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add 'image-text-to-text' to TASK_MAPPING #37107

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

saattrupdan
Copy link
Contributor

What does this PR do?

The TASK_MAPPING dictionary, mapping pipeline tags to the list of architectures that support that task, is missing the new image-text-to-text pipeline tag. This PR simply adds that missing one.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker @amyeroberts @qubvel

@github-actions github-actions bot marked this pull request as draft March 29, 2025 16:26
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@saattrupdan saattrupdan marked this pull request as ready for review March 29, 2025 16:27
@Rocketknight1
Copy link
Member

This is in modelcard.py so cc @stevhliu as well

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for updating!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saattrupdan
Copy link
Contributor Author

@stevhliu @qubvel Thanks both! It doesn't seem like the failing test has anything to do with my change though?

@stevhliu
Copy link
Member

stevhliu commented Apr 1, 2025

Yeah it seems unrelated, we can merge for you once a fix has been released on main :)

@saattrupdan
Copy link
Contributor Author

Yeah it seems unrelated, we can merge for you once a fix has been released on main :)

It seems like the issue has been fixed on main now, but I can't re-trigger the tests - are you able to?

@qubvel
Copy link
Member

qubvel commented Apr 2, 2025

cc @ydshieh to merge 🤗

@ydshieh
Copy link
Collaborator

ydshieh commented Apr 2, 2025

Thank you for the pin. I just merge some fix, let's update the branch (I am doing it now) to see if my patch work well or not 🙏

@ydshieh
Copy link
Collaborator

ydshieh commented Apr 2, 2025

well, happy it works (at least for some runs so far)

@ydshieh ydshieh merged commit e94d607 into huggingface:main Apr 2, 2025
18 checks passed
@saattrupdan saattrupdan deleted the patch-1 branch April 2, 2025 13:57
zucchini-nlp pushed a commit to BakerBunker/transformers that referenced this pull request Apr 2, 2025
Co-authored-by: Yih-Dar <2521628+ydshieh@users.noreply.github.com>
duanjunwen pushed a commit to duanjunwen/transformers that referenced this pull request Apr 3, 2025
Co-authored-by: Yih-Dar <2521628+ydshieh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants