Add Fast Image Processor for MobileNetV1 #37111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
69 tasks
yonigozlan
reviewed
Apr 2, 2025
There was a problem hiding this comment.
Hi @dmdaksh , thanks for contributing this! Just two small things to change/add, and then LGTM!
src/transformers/models/mobilenet_v1/image_processing_mobilenet_v1_fast.py
Outdated
Show resolved
Hide resolved
dmdaksh
force-pushed
the
mobilenetv1_fast_image_processor
branch
from
0a56051 to
36002d1
Compare
yonigozlan
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Great @dmdaksh thanks for iterating, LGTM after getting @ArthurZucker final approval :)
dmdaksh
force-pushed
the
mobilenetv1_fast_image_processor
branch
2 times, most recently
from
77af7be to
938047f
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
* fast image processor template for MobileNetV1 via transformers-cli * Add fast image processors and unify tests for slow/fast image processor classes * added loop over image_processor_list for all tests and removed boilerplate comments. --------- Co-authored-by: Yoni Gozlan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to #36978
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.