Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RWKV: fix mask warning typo #37114

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

RobinKa
Copy link
Contributor

@RobinKa RobinKa commented Mar 30, 2025

RwKvModel.forward is supposed to warn if attention_mask is passed. Right now the check is attention_mask is None which I assume was supposed to be attention_mask is not None, which this PR fixes. @gante

@github-actions github-actions bot marked this pull request as draft March 30, 2025 12:40
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@RobinKa RobinKa marked this pull request as ready for review March 30, 2025 12:40
@github-actions github-actions bot requested a review from ArthurZucker March 30, 2025 12:41
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ArthurZucker ArthurZucker merged commit d1efaf0 into huggingface:main Mar 31, 2025
14 checks passed
zhouksh pushed a commit to zhouksh/transformers that referenced this pull request Mar 31, 2025
zhouksh pushed a commit to zhouksh/transformers that referenced this pull request Apr 1, 2025
dmdaksh pushed a commit to dmdaksh/transformers that referenced this pull request Apr 2, 2025
zucchini-nlp pushed a commit to BakerBunker/transformers that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants