Skip to content

[bug] fsdp training save checkpoint twice #37417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cyr0930
Copy link

@cyr0930 cyr0930 commented Apr 10, 2025

What does this PR do?

FSDP training save checkpoint twice as pytorch_model_fsdp.bin and model.safetensors.
And saving model during calling _save_optimizer_and_scheduler is not intuitive.

(Maybe I have to rename final checkpoint or save it as safetensors format.)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@zach-huggingface @SunMarc

@github-actions github-actions bot marked this pull request as draft April 10, 2025 09:48
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There a two kinds of checkpoints:

  • one that can we reloaded with from_pretrained
  • one that we use for resuming the training

So, this is normal that the model is saved twice. However, it might make sense to only save the checkpoint with from_pretrained compatibility in the last checkpoint by default.

cc @S1ro1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants