Fix wrong argparse type in modular checker script #37472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
Rocketknight1
force-pushed
the
fix-check-modular-conv-argparse
branch
from
57ea113 to
37721fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In the
argparselibrary, thetypeparameter is applied to each argument individually. When usingtype=listin combination withnargs="+", the commandpython utils/check_modular_conversion.py --files abc defis parsed as[['a', 'b', 'c'], ['d', 'e', 'f']]. This behavior occurs because the script typically relies on no arguments being passed, defaulting to['all'], which has allowed it to function correctly until now.This PR corrects this behaviour.
CC: @ArthurZucker