Skip to content

Accept processor in get_training_chat_template#5560

Open
qgallouedec wants to merge 20 commits intomainfrom
processor-in-get_training_chat_template
Open

Accept processor in get_training_chat_template#5560
qgallouedec wants to merge 20 commits intomainfrom
processor-in-get_training_chat_template

Conversation

@qgallouedec
Copy link
Copy Markdown
Member

@qgallouedec qgallouedec commented Apr 15, 2026

get_training_chat_template already works on both PreTrainedTokenizer and ProcessorMixin. The type hint, parameter name, and docstring were misleading by saying "tokenizer" only. Call sites (e.g. GRPOTrainer, SFTTrainer) already pass processing_class.


Note

Low Risk
Mostly an API/typing/doc clarification with a backwards-compatible alias and minimal logic changes; risk is limited to edge cases around argument validation/warning behavior.

Overview
get_training_chat_template now takes a processing_class (tokenizer or ProcessorMixin) and updates its docs/types accordingly, aligning the public API with existing processor-based call sites.

For backward compatibility it keeps a deprecated tokenizer alias, emitting a FutureWarning, validating that only one of the two args is passed, and improving the error message wording when patching is unsupported.

Reviewed by Cursor Bugbot for commit e0fb2e1. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aa61a92ea2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread trl/chat_template_utils.py Outdated
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6700975. Configure here.

Comment thread trl/chat_template_utils.py
Comment thread trl/chat_template_utils.py Outdated
Copy link
Copy Markdown
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is red:

AttributeError: 'NoneType' object has no attribute 'chat_template'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants