Set _tokenizer attribute in experimental trainers#5566
Merged
albertvillanova merged 20 commits intohuggingface:mainfrom Apr 28, 2026
Merged
Set _tokenizer attribute in experimental trainers#5566albertvillanova merged 20 commits intohuggingface:mainfrom
albertvillanova merged 20 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ad61f84. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Set
_tokenizerattribute in experimental trainers.Follow-up to:
Note
Medium Risk
Broad but mechanical refactor touching padding/EOS IDs in several training and generation paths; a missed reference could cause runtime errors or subtle masking/padding behavior changes.
Overview
Standardizes tokenizer handling across experimental trainers by storing the resolved tokenizer on
self._tokenizer(from either aProcessorMixinor aPreTrainedTokenizerBase) and ensuringpad_tokendefaults toeos_tokenwhen missing.Updates all downstream uses (data collators, dataset preprocessing EOS appends, padding/gathering logic, and generation configs/EOS detection) to reference
self._tokenizer.*instead of localtokenizervariables or separateself.pad_token_id/self.eos_token_idfields.Reviewed by Cursor Bugbot for commit ba22aad. Bugbot is set up for automated code reviews on this repo. Configure here.