-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix missing PEFT availability check when passing peft_config to experimental trainers #5665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
83b3d69
Fix missing PEFT availability check for peft_config in exp trainers
albertvillanova 32e8764
Fix missing PEFT availability check in BCO
albertvillanova 34a141b
Fix missing PEFT availability check in CPO
albertvillanova 8eb11c5
Fix missing PEFT availability check in KTO
albertvillanova 0d6660d
Fix missing PEFT availability check in ORPO
albertvillanova 3a62cf9
Fix missing PEFT availability check in PPO
albertvillanova 3f3be7b
Add TypeError check to Distillation
albertvillanova f571155
Add TypeError check to PPO
albertvillanova d2664dc
Add TypeError check to TPO
albertvillanova e7242f3
Add TypeError check to BCO
albertvillanova 1392892
Add TypeError check to CPO
albertvillanova 811f87f
Add TypeError check to KTO
albertvillanova 3d487c8
Add TypeError check to ORPO
albertvillanova ef4149d
Add PEFT validation to PRM
albertvillanova 7179659
Add PEFT validation to OnlineDPO
albertvillanova d0a7562
Remove redundant duplicate condition check in Distillation
albertvillanova d236c55
Merge remote-tracking branch 'upstream/main' into fix-peft-validation…
albertvillanova 9f2cd22
Add PEFT validation to SDFT
albertvillanova 81cb6f2
Add PEFT validation to BaseSelfDistillation
albertvillanova 81153c8
Add PEFT validation to SSD
albertvillanova 70b898f
Merge remote-tracking branch 'upstream/main' into fix-peft-validation…
albertvillanova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.