Fix peft_config type hint in experimental trainers#5666
Open
albertvillanova wants to merge 8 commits intomainfrom
Open
Fix peft_config type hint in experimental trainers#5666albertvillanova wants to merge 8 commits intomainfrom
albertvillanova wants to merge 8 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1ea5f27. Configure here.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix
peft_configtype hint in experimental trainers.This PR refactors the PEFT configuration handling in experimental trainer classes (
BCOTrainer,CPOTrainer,KTOTrainer, andORPOTrainer). The main improvement is replacing the previous use of a genericdictforpeft_configwith the more specific and type-safePeftConfigfrom thepeftlibrary. This change enhances type safety, improves documentation clarity, and ensures consistency across the codebase.Changes
PEFT configuration improvements:
The
peft_configparameter in all experimental trainer classes is now typed asPeftConfig | Noneinstead ofdict | None, and the corresponding docstrings have been updated to reflect this change. This ensures better type checking and clearer intent for users and developers.The import statements in all trainer files have been updated to import
PeftConfigfrom thepeftlibrary, alongside the existing PEFT-related imports.Note
Low Risk
Low risk: changes are limited to type hints/imports and docstrings around
peft_config, with no functional training logic modifications.Overview
Type-safety cleanup for PEFT configs in experimental trainers.
Updates
BCOTrainer,CPOTrainer,KTOTrainer,ORPOTrainer,PRMTrainer,NashMDTrainer, andXPOTrainerto acceptpeft_configasPeftConfig | None(and documents it as such) instead ofdict | None, and adds the correspondingPeftConfigimports where PEFT is available.Reviewed by Cursor Bugbot for commit a719702. Bugbot is set up for automated code reviews on this repo. Configure here.