Fix paper_index paths and add GOLD, IW-OPD, and AsyncDistillation telemetry - #7051
Open
YeonwooSung wants to merge 1 commit into
Open
Fix paper_index paths and add GOLD, IW-OPD, and AsyncDistillation telemetry#7051YeonwooSung wants to merge 1 commit into
YeonwooSung wants to merge 1 commit into
Conversation
…emetry Correct the Online DPO module path, the LD-DPO sentence, and a grammar nit. Give GOLD its own paper_index subsection, add an IW-OPD docs page, and list AsyncDistillationTrainer in the telemetry allowlist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Small docs and telemetry hygiene on current main:
paper_index.mdpointed Online DPO at the nonexistentexperimental.odpomodule. The real package isexperimental.online_dpo.GOLDTrainer._paper(no papers id in that citation).docs/source/iw_opd_trainer.mdand an Experimental toctree row.AsyncDistillationTrainerwas missing from_TELEMETRY_TRAINERS, so it reported as"other".No trainer behavior changes except the one-line telemetry allowlist.
Fixes #7048
Before submitting
AI writing disclosure
We welcome the use of AI tools to help with contributions. For transparency and to help us improve our review process, please indicate the level of AI involvement in this PR.
Who can review?
Anyone in the community is free to review the PR once the tests have passed.
Note
Low Risk
Changes are limited to documentation and a one-line telemetry allowlist entry; no training, auth, or data-handling behavior is modified.
Overview
This PR is mostly documentation and telemetry hygiene—no trainer training logic changes beyond the telemetry allowlist.
Paper index fixes broken or unclear references: Online DPO now points at
experimental.online_dpoinstead of the nonexistentexperimental.odpo, the LD-DPO blurb is completed (α=1 recovers standard DPO), and a small grammar fix (“TRL also provides…”). The distillation section gains a dedicated GOLD subsection with project context and aGOLDConfigexample that highlightsuse_uld_loss=Truefor cross-tokenizer distillation.IW-OPD gets a first-class experimental docs page (
iw_opd_trainer.md) with usage,IWOPDConfig/IWOPDTrainerautodoc, and a matching Experimental toctree entry.Telemetry:
AsyncDistillationTraineris added to_TELEMETRY_TRAINERSinbase_trainer.pyso usage is reported under the correct trainer name instead of"other".Reviewed by Cursor Bugbot for commit 9e8e016. Bugbot is set up for automated code reviews on this repo. Configure here.