Don't log expected reconstruction 416 as a failed api call - #939
Draft
assafvayner wants to merge 2 commits into
Draft
Don't log expected reconstruction 416 as a failed api call#939assafvayner wants to merge 2 commits into
assafvayner wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downloads walk a file by requesting successive reconstruction segments until the server answers 416 (Range Not Satisfiable), so that 416 is the normal end-of-file signal rather than a failure. It was still routed through
process_error, which logged"... api call failed ..."at info level for every completed file download.with_expected_416()now logs a single debug line (Reached end of reconstruction) and skips the failure-wordedprocess_errorpath; the caller still gets the same fatal, non-retried error thatget_reconstruction_implconverts toOk(None).test_416_expected_is_fatal_and_not_logged_as_failure, which asserts no ERROR/WARN and no"api call failed"line is emitted.