No concessions to code quality !

hugues-m · Oct 7, 2015 · 0b631ad · 0b631ad
1 parent 5587144
commit 0b631ad
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 7 deletions.
diff --git a/src/HMLB/PHPUnit/Listener/VWListener.php b/src/HMLB/PHPUnit/Listener/VWListener.php
@@ -107,4 +107,3 @@ public function endTestSuite(PHPUnit_Framework_TestSuite $suite)
     {
     }
 }
-
diff --git a/src/HMLB/VW/SecretSoftware.php b/src/HMLB/VW/SecretSoftware.php
@@ -3,9 +3,9 @@
 namespace HMLB\VW;
 
 use PHPUnit_Framework_TestCase;
-use PHPUnit_Framework_TestResult;
 use PHPUnit_Runner_BaseTestRunner;
 use ReflectionClass;
+use ReflectionProperty;
 
 /**
  * You didn't see that.
@@ -85,8 +85,7 @@ public function force(PHPUnit_Framework_TestCase $test)
      */
     private function forcePropertyValue(ReflectionClass $reflection, $property, $value, $object)
     {
-        $propertyReflection = $reflection->getProperty($property);
-        $propertyReflection->setAccessible(true);
+        $propertyReflection = $this->accessProperty($reflection, $property);
         $propertyReflection->setValue($object, $value);
         $propertyReflection->setAccessible(false);
 
@@ -102,11 +101,24 @@ private function forcePropertyValue(ReflectionClass $reflection, $property, $val
      */
     private function getPropertyValue(ReflectionClass $reflection, $property, $object)
     {
-        $propertyReflection = $reflection->getProperty($property);
-        $propertyReflection->setAccessible(true);
+        $propertyReflection = $this->accessProperty($reflection, $property);
         $value = $propertyReflection->getValue($object);
         $propertyReflection->setAccessible(false);
 
         return $value;
     }
+
+    /**
+     * @param ReflectionClass $reflection
+     * @param string          $property
+     *
+     * @return ReflectionProperty
+     */
+    private function accessProperty(ReflectionClass $reflection, $property)
+    {
+        $propertyReflection = $reflection->getProperty($property);
+        $propertyReflection->setAccessible(true);
+
+        return $propertyReflection;
+    }
 }
diff --git a/src/Tests/VWTest.php b/src/Tests/VWTest.php
@@ -22,4 +22,3 @@ public function testEnvironmentalImpactCompliance()
         $this->assertLessThan($this->legalLimit, $this->noxEmissions);
     }
 }
-
Original file line number	Diff line number	Diff line change
Expand Up		@@ -107,4 +107,3 @@ public function endTestSuite(PHPUnit_Framework_TestSuite $suite)
		{
		}
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -22,4 +22,3 @@ public function testEnvironmentalImpactCompliance()
		$this->assertLessThan($this->legalLimit, $this->noxEmissions);
		}
		}