Skip to content

xml reader: don't block attempt to read from stdin using wxr-importer import php://stdin#147

Open
drzraf wants to merge 1 commit into
humanmade:masterfrom
drzraf:read-stdin
Open

xml reader: don't block attempt to read from stdin using wxr-importer import php://stdin#147
drzraf wants to merge 1 commit into
humanmade:masterfrom
drzraf:read-stdin

Conversation

@drzraf

@drzraf drzraf commented Aug 21, 2017

Copy link
Copy Markdown

No description provided.

@rmccue

rmccue commented Aug 21, 2017

Copy link
Copy Markdown
Member

To fit better with how CLI apps generally work, you should pass - instead, and we should handle that if we don't already.

@drzraf

drzraf commented Aug 21, 2017

Copy link
Copy Markdown
Author

addressed

@drzraf

drzraf commented Aug 22, 2017

Copy link
Copy Markdown
Author

side note:
If this can be merged : wp-cli/export-command#9 ...
then it'd be possible to test transformation identity (admitting an --override flag would exist) by checking that such an operation...
$ wp export --stdout | wp wxr-importer import --override -
... implied no change on the source database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants