Skip to content

Update config on certificate change #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 12, 2025

Conversation

Sephsekla
Copy link
Contributor

@Sephsekla Sephsekla commented Mar 7, 2025

We have a site using HM-ACM which sometimes requires updating the certificate and Cloudfront distribution with new domains. This PR makes a few changes to improve this workflow:

  • Added documentation for some functions.
  • Allow showing/hiding of the unlink buttons for both certificates and distributions. In our use case, there's not a use case for unlinking the distribution and it's a more involved process to relink it (although I'd like to add the option to relink via a button as a followup). This avoids accidental clicks that can't be easily resolved from within the dashboard.
  • Add a check for whether the Cloudfront distribution is using the correct certificate, and warning the user if not.
  • Display the certificate and distribution details (within an accordion) to allow for easier debugging and checking that distributions/certificates match.

I've made this PR against #15, which I'm hoping we can also get merged and into a release. I have a couple of slightly more opinionated readability improvements as well, but I'll address those in a followup so they don't block this.

@Sephsekla Sephsekla self-assigned this Mar 10, 2025
@Sephsekla Sephsekla marked this pull request as ready for review March 10, 2025 11:49
@Sephsekla Sephsekla requested review from joehoyle and Rayhatron March 10, 2025 11:50
Copy link
Contributor

@Rayhatron Rayhatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good !! Just need a safety check for a fatal error that's occurring.

@Sephsekla Sephsekla requested a review from Rayhatron March 10, 2025 14:11
Copy link
Contributor

@Rayhatron Rayhatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the fatal error is no longer happening.

Base automatically changed from create-function-request-policy to master March 12, 2025 12:32
@joehoyle joehoyle merged commit 58f9270 into master Mar 12, 2025
@joehoyle joehoyle deleted the update-config-on-change-certificate branch March 12, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants