Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severity assessment initialization #8

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

DBartlettHP
Copy link
Collaborator

This is the initial state of current severity calculation functions.

HASI-R is the only non-working function at the moment. (Depends on data for region information)

…e still updated my local repository, and now I cannot see my changes upon commit.)
Copy link
Member

@billdenney billdenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! (I realize that there remains more to do.)

R/hasi.R Outdated Show resolved Hide resolved
R/HS_PGA_char.R Outdated Show resolved Hide resolved
R/HS_PGA_num.R Outdated Show resolved Hide resolved
R/HiSCR.R Outdated Show resolved Hide resolved
R/IHS4_char.R Outdated Show resolved Hide resolved
R/HS_PGA_num.R Outdated Show resolved Hide resolved
R/HiSCR.R Outdated Show resolved Hide resolved
R/IHS4_char.R Outdated Show resolved Hide resolved
R/IHS4_num.R Outdated Show resolved Hide resolved
R/hasi.R Outdated Show resolved Hide resolved
Copy link
Member

@billdenney billdenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DBartlettHP, This looks like some good work! Can you please take a look at the comments?

R/hasi.R Outdated Show resolved Hide resolved
tests/testthat/test-HS_PGA_char.R Show resolved Hide resolved
tests/testthat/test-HS_PGA_char.R Show resolved Hide resolved
tests/testthat/test-HS_PGA_num.R Show resolved Hide resolved
tests/testthat/test-HiSCR.R Show resolved Hide resolved
R/HS_PGA_char.R Outdated Show resolved Hide resolved
R/HS_PGA_num.R Show resolved Hide resolved
R/HS_PGA_num.R Show resolved Hide resolved
@billdenney
Copy link
Member

I'm going to merge this and then make some individual issues/pull requests to resolve some of the comments.

@billdenney billdenney merged commit 6a0f480 into main Jun 3, 2024
7 checks passed
@billdenney billdenney deleted the severity_assessment_initialization branch June 3, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants