Skip to content

fix(web): reload open tabs after relaunch (CORR-434) - #258

Merged
david-hummingbot merged 1 commit into
mainfrom
fix/corr-434-reload-open-tab-after-relaunch
Sep 30, 2026
Merged

david-hummingbot merged 1 commit into
mainfrom
fix/corr-434-reload-open-tab-after-relaunch

Conversation

@cardosofede

Copy link
Copy Markdown
Contributor

CORR-434

After users update Condor, the update run reports success, but an already-open tab keeps serving the pre-update frontend bundle.

The relaunch banner clears when the process restarts and relaunch_pending() becomes false. That makes the indicator disappear even though the tab is still running the old bundle.

The banner now uses a hook that reloads the open tab once after its relaunch poll observes a successful required: true to required: false transition. That transition means the relaunched server is answering, so the tab can load the updated bundle. Failed polls, an initial false result, and later false results do not cause a reload.

Reloading when the update run reports success was rejected because it could put the new bundle in front of the old API before the process restarts. A fetch or autoUpdate service worker was also rejected because condor/web/app.py already handles bundle caching correctly; this is a stale open-tab lifecycle issue.

Verification from the implementation run: frontend tests passed (217 files, 2,260 tests), production build passed, lint:ci passed, and changed-file lint passed. Repository-wide npm run lint still reports 41 pre-existing baselined errors unrelated to this change.

@greptile-apps

greptile-apps Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Medium risk] Adds automatic page reload when server relaunches.

The PR should not merge until an open tab can recover when it misses the temporary relaunch-pending state.

Findings

  1. P1 Missed relaunch leaves tabs stale ▶

Summary

The PR moves relaunch handling into a hook that reloads an open dashboard tab after observing required: true followed by required: false, and adds transition tests.

  • The reload depends on observing a temporary state; an update and restart missed between polls can leave the tab stale.

Reviews (1) · Last reviewed commit: "fix(web): reload open tabs after relaunc..."

Comment thread frontend/src/hooks/useRelaunch.ts
@david-hummingbot
david-hummingbot merged commit f15e401 into main Sep 30, 2026
5 checks passed
@david-hummingbot
david-hummingbot deleted the fix/corr-434-reload-open-tab-after-relaunch branch September 30, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants