Repository navigation
fix(web): reload open tabs after relaunch (CORR-434) - #258
Merged
david-hummingbot merged 1 commit intoSep 30, 2026
Merged
Conversation
|
david-hummingbot
approved these changes
Sep 30, 2026
david-hummingbot
deleted the
fix/corr-434-reload-open-tab-after-relaunch
branch
September 30, 2026 08:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CORR-434
After users update Condor, the update run reports success, but an already-open tab keeps serving the pre-update frontend bundle.
The relaunch banner clears when the process restarts and
relaunch_pending()becomes false. That makes the indicator disappear even though the tab is still running the old bundle.The banner now uses a hook that reloads the open tab once after its relaunch poll observes a successful
required: truetorequired: falsetransition. That transition means the relaunched server is answering, so the tab can load the updated bundle. Failed polls, an initial false result, and later false results do not cause a reload.Reloading when the update run reports success was rejected because it could put the new bundle in front of the old API before the process restarts. A fetch or
autoUpdateservice worker was also rejected becausecondor/web/app.pyalready handles bundle caching correctly; this is a stale open-tab lifecycle issue.Verification from the implementation run: frontend tests passed (217 files, 2,260 tests), production build passed,
lint:cipassed, and changed-file lint passed. Repository-widenpm run lintstill reports 41 pre-existing baselined errors unrelated to this change.