Conversation
|
| max_controller_drawdown_quote=max_controller_drawdown_quote, | ||
| image=image, | ||
| ) | ||
| async with hummingbot_client.deployment_client() as client: |
There was a problem hiding this comment.
Deployment loses connection retries
If the API briefly refuses connections before deployment, the new client makes no retryable readiness check before its first deployment POST. The previous shared-client path retried its accounts check according to max_retries, so a deployment that could have succeeded after the API recovered now fails. Restore retries for a pre-deployment check without retrying the POST when its outcome is unknown.
Bot deployment can finish after the Hummingbot API client's default 30-second timeout. In the observed case, the tool reported
Failed to manage bots:while the backend created the bot roughly 42 seconds after the request, leaving the agent uncertain whether deployment succeeded.This change gives
manage_bots(action="deploy")a temporary SDK client with a timeout of at least 120 seconds, preserving any larger configured timeout. Other actions continue using the shared client. The temporary client closes on success, initialization failure, and cancellation.If deployment still times out, the tool explicitly reports an unknown outcome, names the bot, controller configs, and account, and tells the agent to reconcile before retrying. It sends one deployment POST and performs no automatic deployment retry.
Validation: