Multiple code improvements - squid:S1319, squid:S2583, squid:S1301, squid:SwitchLastCaseIsDefaultCheck, squid:S1141, squid:S1151, squid:S1854#3
Open
georgekankava wants to merge 1 commit intohuxq17:masterfrom
DevFactory:release/multiple-code-improvements-fix-1
Open
Multiple code improvements - squid:S1319, squid:S2583, squid:S1301, squid:SwitchLastCaseIsDefaultCheck, squid:S1141, squid:S1151, squid:S1854#3georgekankava wants to merge 1 commit intohuxq17:masterfrom DevFactory:release/multiple-code-improvements-fix-1
georgekankava wants to merge 1 commit intohuxq17:masterfrom
DevFactory:release/multiple-code-improvements-fix-1
Conversation
…quid:SwitchLastCaseIsDefaultCheck, squid:S1141, squid:S1151, squid:S1854
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rules
squid:S1319 - Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList".
squid:S2583 - Conditions should not unconditionally evaluate to "TRUE" or to "FALSE".
squid:S1301 - "switch" statements should have at least 3 "case" clauses.
squid:SwitchLastCaseIsDefaultCheck - "switch" statements should end with a "default" clause.
squid:S1141 - Try-catch blocks should not be nested.
squid:S1151 - "switch case" clauses should not have too many lines.
squid:S1854 - Dead stores should be removed.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1319
https://dev.eclipse.org/sonar/rules/show/squid:S2583
https://dev.eclipse.org/sonar/rules/show/squid:S1301
https://dev.eclipse.org/sonar/rules/show/squid:SwitchLastCaseIsDefaultCheck
https://dev.eclipse.org/sonar/rules/show/squid:S1141
https://dev.eclipse.org/sonar/rules/show/squid:S1151
https://dev.eclipse.org/sonar/rules/show/squid:S1854
Please let me know if you have any questions.
George Kankava