Multiple code improvements - squid:S00112, squid:S1226, squid:S1444, squid:ClassVariableVisibilityCheck, squid:S3008#4
Open
georgekankava wants to merge 1 commit intohuxq17:masterfrom
DevFactory:release/multiple-code-improvements-fix-2
Open
Multiple code improvements - squid:S00112, squid:S1226, squid:S1444, squid:ClassVariableVisibilityCheck, squid:S3008#4georgekankava wants to merge 1 commit intohuxq17:masterfrom DevFactory:release/multiple-code-improvements-fix-2
georgekankava wants to merge 1 commit intohuxq17:masterfrom
DevFactory:release/multiple-code-improvements-fix-2
Conversation
…squid:ClassVariableVisibilityCheck, squid:S3008
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rules
squid:S00112 - Generic exceptions should never be thrown.
squid:S1226 - Method parameters, caught exceptions and foreach variables should not be reassigned.
squid:S1444 - "public static" fields should be constant.
squid:ClassVariableVisibilityCheck - Class variable fields should not have public accessibility.
squid:S3008 - Static non-final field names should comply with a naming convention.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S00112
https://dev.eclipse.org/sonar/rules/show/squid:S1226
https://dev.eclipse.org/sonar/rules/show/squid:S1444
https://dev.eclipse.org/sonar/rules/show/squid:ClassVariableVisibilityCheck
https://dev.eclipse.org/sonar/rules/show/squid:S3008
Please let me know if you have any questions.
George Kankava