修复控制台报的错，重构部分代码，做出一些优化 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huxulm
reviewed
Feb 21, 2025
| @@ -0,0 +1,5 @@ | |||
| import { BinaryLike, createHash } from "crypto"; | |||
There was a problem hiding this comment.
你在这里使用 NodeJS std 库里面的 "crypto" 在构建项目 (pnpm build or npm build) 的时候有没有报错？或者你这里单独安装了浏览器版本的实现吗？
There was a problem hiding this comment.
没有安装别的，我是pnpm install下载的依赖，然后我本地的pnpm-lock.json没有上传，package.json没有变化，然后我本地run dev没有报错
There was a problem hiding this comment.
可以验证一下 "pnpm build", fail 的话可能需要安装一个 es6 模块的 crypto。
|
@huxulm RatingCircle组件有个错误导致build失败，我本地不需要安装crypto就能build
把错误改掉之后就能build
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:
refactor:
optimize:
feature: