KWIC Functionality added!#51
Open
harisalam wants to merge 5 commits into
Open
Conversation
Owner
|
Can you do a pull request to the dev branch instead or just create a new branch? |
Contributor
Author
|
Okay, I'll do a pull request to the dev branch! |
| r'C:\Users\haris\Desktop\wordFinder\haris.txt') | ||
| # udt_english = UdpipeTrain(language_list[1], | ||
| # r'C:\Users\haris\Desktop\wordFinder\english-ewt-ud-2.5-191206.udpipe', | ||
| # r'C:\Users\haris\Desktop\wordFinder\haris.txt') |
Collaborator
There was a problem hiding this comment.
This line is commented to are you using this as a safe reference?
| {% for cluster_sentence in cluster_result %} | ||
| <li class="list-group-item d-flex justify-content-between align-items-center"> | ||
| {{cluster_sentence}} | ||
| # Add KWIC Functinality |
Collaborator
There was a problem hiding this comment.
I think, anyone need to add KWIC functionality code here.
Collaborator
Akhilraj03-Github
left a comment
Akhilraj03-Github
left a comment
There was a problem hiding this comment.
Did 5 reviews, Will do code reviews for other remaining files of this commit.
Collaborator
|
Solved all the 8 merge conflicts for the master branch from the haris KWIC newfeature branch. |
| db_config['host'], | ||
| db_config['database']) | ||
| db_config['db_host'], | ||
| db_config['db_name']) |
Collaborator
There was a problem hiding this comment.
OK, Nice one Haris
| cleaned_data = re.sub('\w*\d\w*', '', data) | ||
| cleaned_data = re.sub('\[.*?\]', '', cleaned_data) | ||
| cleaned_data = re.sub('[‘’“”…]','',cleaned_data) | ||
| cleaned_data = re.sub('[‘’“”…]', '', cleaned_data) |
Collaborator
There was a problem hiding this comment.
Is there a big difference between these two?
| if word.lemma and word.lemma not in string.punctuation: | ||
| if word.lemma and word.upostag and sentence_text: | ||
| combined_words .append(TResult(word.lemma, word.upostag, sentence_text)) | ||
| combined_words.append(TResult(word.lemma, word.upostag, sentence_text)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need integration of KWIC functionality with webapp...