added library.properties#4
Open
marcobrianza wants to merge 3 commits into
Open
Conversation
per1234
suggested changes
May 31, 2018
| author=hwwong | ||
| maintainer=hwwong | ||
| sentence=ESP32 / ESP8266 influxdb client. | ||
| paragraph=ESP32 / ESP8266 influxdb client, posts and queries data |
There was a problem hiding this comment.
The Arduino IDE's Library Manager displays the text defined in the library.properties paragraph field immediately after the sentence text so it's not desirable to duplicate the sentence text in paragraph.
| paragraph=ESP32 / ESP8266 influxdb client, posts and queries data | ||
| category=Data Storage | ||
| url=https://github.com/hwwong/ESP_influxdb | ||
| architectures=ESP8266,ESP32 |
There was a problem hiding this comment.
Architectures value is case sensitive and the correct case of these architecture values is esp8266 and esp32. The current values causes the example to appear under File > Examples > INCOMPATIBLE and a warning to be shown when compiling the library:
WARNING: library ESP_influxdb claims to run on (ESP8266, ESP32) architecture(s) and may be incompatible with your current board which runs on (esp8266) architecture(s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello, nice library.
I have just added the library.properties for arduino libray manager compatibility.
to make it available to the community you should also make a release on github .
to make it available to all with the library manger please give a look at this:
https://github.com/arduino/Arduino/wiki/Library-Manager-FAQ