Skip to content

Normalize test package names - #17

Merged
hyfdev merged 1 commit into
mainfrom
agent/test-package-names
Aug 16, 2026
Merged

hyfdev merged 1 commit into
mainfrom
agent/test-package-names

Conversation

@hyfdev

@hyfdev hyfdev commented Aug 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • rename the private Node and Wasm test workspaces to tests-taffy-node and tests-taffy-wasm
  • update Vite+ task selectors and the Wasm CI workspace filter
  • record and vouch the convention that direct test workspaces use tests-taffy- followed by their corresponding identifier

Why

The existing scoped *-integration-tests names do not follow the newly decided direct naming convention for top-level test packages.

Impact

Only private test workspace identities and their internal task references change. Test directories and public @taffyjs/* package names remain unchanged.

Validation

  • vp fmt --check
  • vp lint --deny-warnings
  • vp run check
  • vp run check:wasm
  • independent adversarial review, with the one map-index finding fixed and the targeted follow-up passing

Copilot AI lite review requested due to automatic review settings August 16, 2026 08:07
@hyfdev
hyfdev merged commit 35ee173 into main Aug 16, 2026
6 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR normalizes the private Node and Wasm test workspace package names to match the newly vouched tests-taffy-<identifier> convention, and updates all task selectors and CI filters that reference those workspaces.

Changes:

  • Renamed tests/taffyjs-node and tests/taffyjs-wasm workspace package.json names to tests-taffy-node / tests-taffy-wasm.
  • Updated Vite+ task commands to target the renamed workspaces.
  • Updated Wasm CI step to filter the renamed workspace and updated PCR docs (ledger + index) to record the naming ruling.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vite.config.ts Updates vp run <workspace>#<task> selectors to use tests-taffy-node / tests-taffy-wasm.
tests/taffyjs-wasm/package.json Renames the private Wasm test workspace package name to tests-taffy-wasm.
tests/taffyjs-node/package.json Renames the private Node test workspace package name to tests-taffy-node.
.github/workflows/ci.yml Updates pnpm workspace filter for the Wasm Playwright install step to tests-taffy-wasm.
.agents/docs/tooling-decisions.md Records and vouches the tests-taffy-<identifier> naming convention for top-level tests/ workspaces.
.agents/docs/README.md Updates the tooling decisions index description to include the new test workspace naming ruling.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

hyfdev added a commit that referenced this pull request Aug 16, 2026
Add the WebAssembly runtime, simplify the native build, and align publishable and internal workspace package names.

Refs: #13, #15, #17, #19, #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants