Repository navigation
Normalize test package names - #17
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR normalizes the private Node and Wasm test workspace package names to match the newly vouched tests-taffy-<identifier> convention, and updates all task selectors and CI filters that reference those workspaces.
Changes:
- Renamed
tests/taffyjs-nodeandtests/taffyjs-wasmworkspacepackage.jsonnames totests-taffy-node/tests-taffy-wasm. - Updated Vite+ task commands to target the renamed workspaces.
- Updated Wasm CI step to filter the renamed workspace and updated PCR docs (ledger + index) to record the naming ruling.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
vite.config.ts |
Updates vp run <workspace>#<task> selectors to use tests-taffy-node / tests-taffy-wasm. |
tests/taffyjs-wasm/package.json |
Renames the private Wasm test workspace package name to tests-taffy-wasm. |
tests/taffyjs-node/package.json |
Renames the private Node test workspace package name to tests-taffy-node. |
.github/workflows/ci.yml |
Updates pnpm workspace filter for the Wasm Playwright install step to tests-taffy-wasm. |
.agents/docs/tooling-decisions.md |
Records and vouches the tests-taffy-<identifier> naming convention for top-level tests/ workspaces. |
.agents/docs/README.md |
Updates the tooling decisions index description to include the new test workspace naming ruling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hyfdev
added a commit
that referenced
this pull request
Aug 16, 2026
hyfdev
added a commit
that referenced
this pull request
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests-taffy-nodeandtests-taffy-wasmtests-taffy-followed by their corresponding identifierWhy
The existing scoped
*-integration-testsnames do not follow the newly decided direct naming convention for top-level test packages.Impact
Only private test workspace identities and their internal task references change. Test directories and public
@taffyjs/*package names remain unchanged.Validation
vp fmt --checkvp lint --deny-warningsvp run checkvp run check:wasm