Skip to content

Add official Yoga compatibility tests - #34

Merged
hyfdev merged 2 commits into
mainfrom
agent/yoga-official-tests
Aug 16, 2026
Merged

hyfdev merged 2 commits into
mainfrom
agent/yoga-official-tests

Conversation

@hyfdev

@hyfdev hyfdev commented Aug 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • vendor the unmodified Yoga 3.2.1 JavaScript test snapshot under tests/taffyjs-yoga/yoga-official/, with its exact commit provenance and MIT license
  • classify the 85 cases covered by published TaffyJS Different or Unsupported boundaries as required failures while preserving Yoga's 17 upstream skips
  • run the same official corpus against both @taffyjs/yoga and @taffyjs/yoga-wasm, and fail closed on every unclassified regression or expected failure that starts passing
  • isolate the classifier in dedicated official-test projects and require every classified title to remain active rather than upstream-skipped
  • document and differentially fixture the oversized cross-axis auto-margin Difference exposed by the official corpus
  • record the snapshot and refresh policy in the Yoga PCR documentation

Coverage

The pinned corpus contains 570 Yoga cases: 468 pass normally, 85 are explicit expected failures, and 17 remain skipped by Yoga. The repository's existing focused compatibility tests remain responsible for the exact replacement behavior of documented differences and rejections.

Validation

  • vp run ready
  • vp run check:wasm:yoga:api
  • full vp run check:wasm
  • byte-for-byte comparison of all 37 copied source files and the license against Yoga commit 042f5013152eb81c1552dec945b88f7b95ca350f
  • independent correctness and maintenance-simplicity reviews, followed by targeted PASS reviews of every fix

@hyfdev
hyfdev force-pushed the agent/yoga-official-tests branch from 8a6b046 to efb36cd Compare August 16, 2026 15:27
@hyfdev
hyfdev marked this pull request as ready for review August 16, 2026 15:35
Copilot AI lite review requested due to automatic review settings August 16, 2026 15:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@hyfdev
hyfdev merged commit 080ab3e into main Aug 16, 2026
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants