Repository navigation
feat(runtime): support Yoga Wasm on Bun and Deno - #35
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands runtime support verification and documentation for @taffyjs/yoga-wasm across Bun and Deno, aligning the published runtime compatibility story with the now-implemented Yoga WebAssembly package and adding CI smoke coverage for the new supported runtimes.
Changes:
- Add a runtime-only smoke harness for
@taffyjs/yoga-wasm(root +/load) and run it on Bun 1.2.0 and Deno 2.2.0 in CI after the WASIP build. - Update the main README runtime table to mark
@taffyjs/yoga-wasmas supported across Node/Bun/Deno and clarify permission expectations. - Synchronize runtime-support statements across package docs, website pages, and PCR docs.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/taffyjs-yoga-wasm/runtime-smoke.mjs | Adds a Bun/Deno smoke test that imports both public Yoga Wasm entries and runs a minimal layout verification. |
| README.md | Updates the runtime compatibility table to reflect Yoga Wasm support on Bun/Deno. |
| packages/taffyjs-yoga-wasm/README.md | Documents Bun/Deno support (and Deno no-permissions claim) for Yoga Wasm. |
| apps/website/yoga/index.md | Updates @taffyjs/yoga runtime support description to include Bun/Deno (native transport). |
| apps/website/yoga-wasm/index.md | Updates @taffyjs/yoga-wasm runtime support description to include Bun/Deno. |
| .github/workflows/ci.yml | Adds Bun and Deno smoke steps for @taffyjs/yoga-wasm in the WASIP job. |
| .agents/docs/technology-stack.md | Updates CI description to include the new Yoga Wasm runtime smokes. |
| .agents/docs/taffyjs-yoga-wasm-package.md | Updates the Yoga Wasm public contract/validation checklist to include Bun/Deno smoke expectations. |
| .agents/docs/intent.md | Aligns the repo intent doc with Bun/Deno runtime support for @taffyjs/yoga and @taffyjs/yoga-wasm. |
| .agents/docs/architecture.md | Updates architecture narrative to describe @taffyjs/yoga as a native transport for Node/Bun/Deno. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+10
to
+19
| const resolvedEntry = import.meta.resolve(packageName); | ||
| const resolvedLoadEntry = import.meta.resolve(loadEntryName); | ||
|
|
||
| if (!resolvedEntry.endsWith("/packages/taffyjs-yoga-wasm/dist/index.js")) { | ||
| throw new Error(`${packageName} resolved to an unexpected entry: ${resolvedEntry}`); | ||
| } | ||
|
|
||
| if (!resolvedLoadEntry.endsWith("/packages/taffyjs-yoga-wasm/dist/load.js")) { | ||
| throw new Error(`${loadEntryName} resolved to an unexpected entry: ${resolvedLoadEntry}`); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@taffyjs/yoga-wasmroot and/loadentries on Bun 1.2.0 and Deno 2.2.0 after the WASIP verification graph builds both packages@taffyjs/yogais a native transport available on Node.js, Bun, and Deno while still excluding browser and WebAssembly backendsWhy
The Yoga WebAssembly package is now implemented, but the runtime table still marked it as unavailable and CI did not exercise it on the supported Bun and Deno minimum endpoints. Its
@taffyjs/wasmbackend already supports both runtimes, including Deno without permission flags, and both Yoga public entries pass at the established minimum versions.Validation
pnpm install --frozen-lockfilepnpm exec vp run check:formatpnpm exec vp run check:lintpnpm exec vp run check:wasmpnpm exec vp run build:websitepnpm dlx bun@1.2.0 tests/taffyjs-yoga-wasm/runtime-smoke.mjspnpm dlx deno@2.2.0 run --node-modules-dir=manual tests/taffyjs-yoga-wasm/runtime-smoke.mjs