Port missed changes from the Python version #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teohhanhui
force-pushed
the
rust-catchup
branch
from
66769e8 to
6558cf3
Compare
|
@teohhanhui Thanks for the update! I've implemented I'm still very new to rust > < |
|
I'll take a look today. |
|
@hykilpikonna Sorry for the delay. I'm going to do a (post-merge) review now. |
teohhanhui
commented
Jan 3, 2025
Thanks anyways! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports from the Python version:
@hykilpikonna I'll leave these up to you 🙏:
[+] Add functionality to print font logo(6f913b6)[F] Fix font logo matching(c1fbd13)[F] Fix windows 7 support (???)(d5b9382)Relevant Links
0ca67a5...master
Screenshots
N/A
Additional context
N/A