Fix min_per_apply_amount zero-status checks in applyOrder#26
Draft
Copilot wants to merge 3 commits into
Draft
Conversation
Co-authored-by: jejolare <85789854+jejolare@users.noreply.github.com>
Co-authored-by: jejolare <85789854+jejolare@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Double check potential issues in branch update
Fix min_per_apply_amount zero-status checks in applyOrder
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in
applyOrdercaused incorrect order zero-status transitions after a transaction, both introduced with themin_per_apply_amount/max_per_apply_amountfeature.Bug 1 —
orderRowzeroed against the wrong constraintorderRowwas being set to'zero'when its post-transactionleftfell belowapplyingOrderRow'smin_per_apply_amount. Each order should be evaluated against its own constraint.Bug 2 — Pre-transaction
leftused forapplyingOrderRowzero checkapplyingOrderLeft(the value before the transaction) was checked againstmin_per_apply_amountinstead ofapplyOrderNewLeft(the value after). The pre-transaction check is vacuously always false — ifapplyingOrderLeftwere already below the minimum, theapplyInvalidgate above would have rejected the request before reaching this point.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.