Add shim for Buffer and add missing dependencies#6
Open
feyyazcigim wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Add missing dependencies and Buffer shim for browser runtime
Description:
This PR addresses the ReferenceError: Buffer is not defined issue when running the scaffold in a browser environment.
What’s Changed:
• Installed and added the following packages to package.json:
• @aztec/bb.js
• @noir-lang/acvm_js
• @noir-lang/noirc_abi
• Added @rollup/plugin-inject to Vite/Rollup config to automatically inject the Buffer global.
• Included fallback shims for Node built-ins in vite.config.ts so that Buffer (and other Node APIs) are available in the browser.
Why:
When importing and using Hyli-related modules (e.g. hyli-wallet), the browser console throws:
Uncaught ReferenceError: Buffer is not defined
Even after manually configuring Buffer in vite.config.ts, the error persisted. These updates ensure that Buffer is properly polyfilled at build time.
Commit Reference:
Changes based on commit e161aa6e95d21c73a2594f3d484fa29db8de8070
Please review and let me know if any further adjustments are needed!