Skip to content

use checked arithmetic in hyllar token transfers #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sertug17 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use checked arithmetic in hyllar token transfers #2016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions crates/contracts/hyllar/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,10 @@ impl ERC20 for Hyllar {
return Err("Insufficient balance".to_string());
}

*self.balances.entry(sender.to_string()).or_insert(0) -= amount;
*self.balances.entry(recipient.to_string()).or_insert(0) += amount;

let sender_entry = self.balances.entry(sender.to_string()).or_insert(0);
*sender_entry = sender_entry.checked_sub(amount).ok_or("Insufficient balance")?;
let recipient_entry = self.balances.entry(recipient.to_string()).or_insert(0);
*recipient_entry = recipient_entry.checked_add(amount).ok_or("Balance overflow")?;
Ok(())
}

Expand All @@ -151,11 +152,12 @@ impl ERC20 for Hyllar {
return Err("Insufficient balance".to_string());
}

*self.balances.entry(owner.to_string()).or_insert(0) -= amount;
*self.balances.entry(recipient.to_string()).or_insert(0) += amount;

let owner_entry = self.balances.entry(owner.to_string()).or_insert(0);
*owner_entry = owner_entry.checked_sub(amount).ok_or("Insufficient balance")?;
let recipient_entry_tf = self.balances.entry(recipient.to_string()).or_insert(0);
*recipient_entry_tf = recipient_entry_tf.checked_add(amount).ok_or("Balance overflow")?;
// Decrease the allowance
let new_allowance = allowance - amount;
let new_allowance = allowance.checked_sub(amount).ok_or("Allowance underflow")?;
self.allowances
.insert((owner.to_string(), spender.to_string()), new_allowance);

Expand Down