fix: prevent stack overflow and double vote in on_prepare#2019
Open
Sertug17 wants to merge 2 commits into
Open
fix: prevent stack overflow and double vote in on_prepare#2019Sertug17 wants to merge 2 commits into
Sertug17 wants to merge 2 commits into
Conversation
replace raw -= and += with checked_sub and checked_add in transfer and transfer_from to prevent silent overflow/underflow wrapping. also fix the same issue in the allowance deduction. defense-in-depth: the balance checks already prevent underflow but checked arithmetic ensures no silent wrapping if the guards ever get out of sync with the actual mutations.
- convert recursive fast-forward to iterative loop to prevent stack overflow with many chained prepares (closes hyli-org#2017) - add double-vote check: skip PrepareVote if the same proposal hash and slot/view was already processed (closes hyli-org#2018)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2017
Closes #2018