Switch profile page when another account selected #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pheuberger is attempting to deploy a commit to the Hypercerts Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Jipperism
requested changes
Mar 27, 2025
pheuberger
force-pushed
the
safe-support-profile-page
branch
from
5ef0817 to
df2eb9f
Compare
This caches the contract check on the server, so that our users don't have to run the same checks individually.
Without this patch, selecting any other account other than your connected EOA using the account selector doesn't do anything on your profile page. However, we want people to be able to cycle through their accounts, so whenever another account is selected via the account selector, we want the profile page to redirect to that account. On the other hand we don't want the profile to automatically switch when the user is on a profile page that is not his connected EOA or one of the multisig they're a signer on. In these cases the selector will do nothing when the account selector is used.
When switching the accounts on the profile page, the unclaimed hypercerts tab wasn't reloaded. It was due to caching, so I removed that. It isn't a lot of data anyway.
pheuberger
force-pushed
the
safe-support-profile-page
branch
from
df2eb9f to
e9f28d9
Compare
Jipperism
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, selecting any other account other than your connected EOA using the account selector doesn't do anything on your profile page. However, we want people to be able to cycle through their accounts, so whenever another account is selected via the account selector, we want the profile page to redirect to that account.
On the other hand we don't want the profile to automatically switch when the user is on a profile page that is not his connected EOA or one of the multisig they're a signer on. In these cases the selector will do nothing when the account selector is used.
ONLY MERGE AFTER #491!