feat: Add delta aggregation for gauge metrics #1151
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1889ae0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (draft) PR represents an alternative delta implementation for gauge metrics in which deltas are calculated between buckets instead of within buckets, and by custom grouping instead of by time-series. This contrasts with the reference implementation in #1147, which does not work for HDX-2323.
This (draft) PR does not include updates to alerts which would likely be required so that consecutive time buckets are queried so that a delta can be calculated.
Testing
Container restarts result in a new ResourceAttributes.container.id value, effectively creating a new timeseries. This results in the reference delta values (in #1147) for each timeseries being 0.
At the pod-level grouping, there are deltas
With this implementation, we can expose those deltas as something that could be alerted on.
