Add Empty
#37
Merged
Add Empty
#37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesaguri
reviewed
Feb 6, 2021
Comment on lines
+27
to
+29
| pub fn new() -> Self { | ||
| Self::default() | ||
| } |
There was a problem hiding this comment.
Structs of this kind are usually created by a freestanding function rather than an associated function (cf. std::future::pending and futures_util::stream::empty).
There was a problem hiding this comment.
I'm open to that but its not my personal preference. I would like to hear what someone else thinks.
|
Possibly related: hyperium/hyper#2345. |
Co-authored-by: Daiki Mizukami <[email protected]>
8 tasks
LucioFranco
approved these changes
Feb 23, 2021
BenxiangGe
pushed a commit
to BenxiangGe/http-body
that referenced
this pull request
Jul 26, 2021
Co-authored-by: Daiki Mizukami <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emptyis a little utility type that I have found useful in a fewscenarios. For example to make a "catch all"
tower::Servicethatalways returns
404 Not Foundwith an empty body.