Skip to content

feat(tls): Add rustls-platform-verifier support#1974

Closed
tottoto wants to merge 1 commit intohyperium:masterfrom
tottoto:add-rustls-platform-verifier-support
Closed

feat(tls): Add rustls-platform-verifier support#1974
tottoto wants to merge 1 commit intohyperium:masterfrom
tottoto:add-rustls-platform-verifier-support

Conversation

@tottoto
Copy link
Collaborator

@tottoto tottoto commented Oct 5, 2024

Adds rustls-platform-verifier support.

@tottoto
Copy link
Collaborator Author

tottoto commented Oct 5, 2024

These are needed for macos and windows.

rustls/rustls-platform-verifier#133
rustls/rustls-platform-verifier#135

@tottoto tottoto force-pushed the add-rustls-platform-verifier-support branch from 100f8a1 to bdbc78b Compare October 10, 2024 14:54
@tobz
Copy link
Collaborator

tobz commented Oct 22, 2024

It would be good to get @djc's thoughts here, since the benefits listed by rustls-platform-verifier itself seem good, albeit small... and it's not clear to me if there are more and/or worse platform support caveats using this vs sticking with rustls-native-certs.

@tobz tobz added C-enhancement Category: New feature or request I-needs-decision Issues in need of decision. labels Oct 22, 2024
@djc
Copy link
Contributor

djc commented Oct 22, 2024

As @tottoto suggested in a previous comment (thought it might not be quite clear), released versions of rustls-platform-verifier don't have all the API in place to support additivity with native-roots and webpki-roots across platforms, so might want to wait for that. The rustls project recommends ~all users migrate away from rustls-native-certs to using the rustls-platform-verifier.

rustls/rustls-platform-verifier#148

@tottoto tottoto force-pushed the add-rustls-platform-verifier-support branch from bdbc78b to cd9131c Compare October 27, 2024 06:40
@tottoto tottoto force-pushed the add-rustls-platform-verifier-support branch from cd9131c to 0788dc2 Compare October 27, 2024 06:41
@tottoto tottoto marked this pull request as draft November 7, 2024 16:37
@LucioFranco
Copy link
Member

Closing for now, feel free to reopen if we want to pick the work back up.

@tottoto tottoto deleted the add-rustls-platform-verifier-support branch June 20, 2025 21:17
@TimOrtel
Copy link

What is the current status for this feature? I have a usecase where I need to support iOS and rustls-native-certs does not work (#1403). Using tls-webpki-roots is not a very good solution for me as I would not like to package certificates with an application, that could use the operating system certificates instead.

Is a workaround available with which it is somehow possible to inject rustls-platform-verifier while this feature is not merged?

Relevant for TimOrtel/GRPC-Kotlin-Multiplatform#60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category: New feature or request I-needs-decision Issues in need of decision.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants